Skip to content

EXTRA_REQUEST_PROMOTED_ONGOINGがEASビルド環境のSDKに未定義のため文字列リテラルに置換#5396

Merged
TinyKitten merged 1 commit intodevfrom
fix/android-build-fail
Feb 21, 2026
Merged

EXTRA_REQUEST_PROMOTED_ONGOINGがEASビルド環境のSDKに未定義のため文字列リテラルに置換#5396
TinyKitten merged 1 commit intodevfrom
fix/android-build-fail

Conversation

@TinyKitten
Copy link
Copy Markdown
Member

@TinyKitten TinyKitten commented Feb 21, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

バグ修正

  • Android通知の継続中ステータスのリクエスト処理を改善しました。

@TinyKitten TinyKitten self-assigned this Feb 21, 2026
@TinyKitten TinyKitten merged commit d7b8d43 into dev Feb 21, 2026
4 of 5 checks passed
@TinyKitten TinyKitten deleted the fix/android-build-fail branch February 21, 2026 03:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 21, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Android LiveUpdateモジュールの通知構築時に、Notification.EXTRA_REQUEST_PROMOTED_ONGOING定数から、同一機能を示す文字列"android.requestPromotedOngoing"への一括置換が行われました。通知構築ロジック全体には変更がなく、メタデータキーの参照方法のみが変更されています。

Changes

Cohort / File(s) Summary
Notification Extras Bundle Key
android/app/src/main/java/me/tinykitten/trainlcd/LiveUpdateModule.kt		 通知の昇格フラグを要求するためのextrasバンドルキーを、Notification.EXTRA_REQUEST_PROMOTED_ONGOING定数から硬輪的な"android.requestPromotedOngoing"文字列に変更。boolean値trueは保持。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Constants hop away, strings take their place,
A notification needs a new face,
"android.requestPromotedOngoing" rings true,
Promoted and onward, our notifications flew! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/android-build-fail

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TinyKitten TinyKitten

Labels

android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TinyKitten